Fixes for React 0.13.x #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +28,7 @@ | |||
| }, | |||
| "homepage": "https://github.com/mzabriskie/react-disqus-thread", | |||
| "dependencies": { | |||
| "react": "^0.12.0" | |||
| "react": "0.12.x - 1.x" | |||
There was a problem hiding this comment.
Also changed this since otherwise the React versions seem to conflict and prevent the component from working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried your component on React 0.13.1, and the injected script to set the
disqus_variables doesn't run. I'm not sure whether it used to work in older versions; this thread says that settinginnerHTMLon a<script>element does not cause the scripts to run: facebook/react#654.In any case, it seems cleaner to me to simply set the variables in
componentDidMount.