Skip to content

Support Harmony re-exports #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Support Harmony re-exports #202

merged 1 commit into from
Dec 6, 2017

Conversation

filipesilva
Copy link
Contributor

Fix #190

@filipesilva
Copy link
Contributor Author

@mzgoddard @rowanoulton @ohze I'm not 100% sure this solves all the re-export problems but on the examples I tried it seemed fine. PTAL.

@Kamilius
Copy link

Kamilius commented Dec 5, 2017

Any news on when this pull request can be merged?

@mzgoddard
Copy link
Owner

@filipesilva @Kamilius Sorry for the delay. This looks great. Thanks!

@mzgoddard
Copy link
Owner

@filipesilva I'm happy enough to see progress made for re-export problems as we find them.

@mzgoddard mzgoddard merged commit 545d796 into mzgoddard:master Dec 6, 2017
@zanettin
Copy link

zanettin commented Dec 6, 2017

@mzgoddard can you give us a note when you've published this fix and on which version? thx a lot @filipesilva ❤️

@mzgoddard
Copy link
Owner

Published as 0.4.12 and 0.5.0-rc.4

@mzgoddard
Copy link
Owner

@zanettin Yup. Had to backport the change a bit to get it in 0.4.

@zanettin
Copy link

zanettin commented Dec 6, 2017

thx a lot @mzgoddard

facing these issues running 0.4.12 and 0.5.0-rc.4:

Starting the development server...

[hard-source:core] HardSourceWebpackPlugin is writing to a new confighash path for the first time: /Users/myApp/node_modules/.cache/hard-source/fdc902b4c070f79b25e3fe2981d322915153030cd5d58a8bea493f96b1a91390

<--- Last few GCs --->

[14422:0x102802400]    43872 ms: Mark-sweep 1405.5 (1584.9) -> 1405.2 (1584.9) MB, 234.9 / 0.0 ms  allocation failure GC in old space requested
[14422:0x102802400]    44112 ms: Mark-sweep 1405.2 (1584.9) -> 1405.1 (1545.9) MB, 240.5 / 0.0 ms  last resort GC in old space requested
[14422:0x102802400]    44344 ms: Mark-sweep 1405.1 (1545.9) -> 1405.1 (1537.4) MB, 231.5 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3447d96a5e91 <JSObject>
    0: builtin exit frame: stringify(this=0x3447d9688ff1 <Object map = 0x344786e82ba1>,0x344774302311 <undefined>,0x344774302311 <undefined>,0x344761e7f5b9 <JSArray[2]>)

    1: arguments adaptor frame: 1->3
    2: /* anonymous */ [/Users/myApp/node_modules/hard-source-webpack-plugin/lib/hard-basic-dependency-plugin.js:~86] [pc=0x35da07b9dc60](this=0x344733b3b649 ...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [/Users/Roman/.nvm/versions/node/v8.8.0/bin/node]

after allocating more memory --max-old-space-size=4096:

Starting the development server...

[hard-source:core] HardSourceWebpackPlugin is writing to a new confighash path for the first time: /Users/myApp/node_modules/.cache/hard-source/fdc902b4c070f79b25e3fe2981d322915153030cd5d58a8bea493f96b1a91390
/Users/myAPp/node_modules/hard-source-webpack-plugin/lib/hard-basic-dependency-plugin.js:99
      var _inContextDependencyIdentifier = module && JSON.stringify([module.context, frozen]);
                                                          ^

RangeError: Invalid string length
    at JSON.stringify (<anonymous>)
    at Compiler.<anonymous> (/Users/myApp/node_modules/hard-source-webpack-plugin/lib/hard-basic-dependency-plugin.js:99:59)

node: 8.8
npm: 5.4.2
webpack: 3.10.0

any ideas? should I open a new issue? thx again

@mzgoddard
Copy link
Owner

@zanettin Yes please open a new issue.

@mzgoddard
Copy link
Owner

@zanettin I'll comment further on the new issue. If you can include any of the following info that'd be helpful:

  • what loaders and plugins your project is using
  • number of modules being built
  • how big is the output js files normally?
  • size of the output destination all together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants