feat: cli #14
Merged
feat: cli #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock
caller needs to figure out the addr before invoking run
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/14/docs/iroh_blobs/ Last updated: 2024-11-18T11:43:59Z |
4 tasks
dignifiedquire
approved these changes
Nov 18, 2024
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Nov 18, 2024
) ## Description <!-- A summary of what this pull request achieves and a rough list of changes. --> ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions Node: depends on n0-computer/iroh-blobs#14 <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add blobs cli from main iroh repo
Breaking Changes
None, this just adds stuff.
Notes & open questions
Currently we just require the caller to figure out the NodeAddr before invoking run. We could have some lazy way to figure out the NodeAddr, like a callback or a trait or even a generic node rpc interface as tried out in n0-computer/iroh#2927. But I think this is nice and simple for now.
Change checklist