Skip to content

feat: Add in-memory rpc client and handler #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 15, 2024
Merged

feat: Add in-memory rpc client and handler #7

merged 7 commits into from
Nov 15, 2024

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Nov 13, 2024

Description

...lazily created so it doesn't cost much if you don't use it

Breaking Changes

  • handle_rpc_request takes self, not &self

Notes & open questions

The RpcHandler stuff should be in quic-rpc maybe, or at least somehow DRYed.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

lazily created so it doesn't cost much if you don't use it
Copy link

github-actions bot commented Nov 13, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/7/docs/iroh_gossip/

Last updated: 2024-11-14T17:03:15Z

@rklaehn rklaehn marked this pull request as ready for review November 14, 2024 17:02
@rklaehn rklaehn merged commit 0eba891 into main Nov 15, 2024
26 checks passed
@rklaehn rklaehn deleted the mem-client branch November 15, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants