Add multipath #28
Draft
Add multipath #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
force-pushed
the
multipath-quinn-0.11.x
branch
from
6f37612 to
f5485c2
Compare
divagant-martian
force-pushed
the
multipath-quinn-0.11.x
branch
from
6fa6b81 to
f3f1a44
Compare
This is a bit sad because it splits the use in poll_transmit. It will need more adjustments once poll_transmit starts sending on multiple paths though.
This is a bit sad because it splits the use in poll_transmit. It will need more adjustments once poll_transmit starts sending on multiple paths though.
On MacOS < 14, with `fast-apple-datapath` feature, calls to
`libc::CMSG_NXTHDR` might continuously return empty (i.e. all zero)
`libc::cmsghdr` instead of a null pointer. This results in a busy loop
in `decode_recv`:
``` rust
let cmsg_iter = unsafe { cmsg::Iter::new(hdr) };
for cmsg in cmsg_iter {
match (cmsg.cmsg_level, cmsg.cmsg_type) {
```
https://github.com/quinn-rs/quinn/blob/b4378bb39dab4b58a1e6a3fea4fff9f87033dab6/quinn-udp/src/unix.rs#L685C1-L687C50
This commit fixes the above, returning a `null_mut()` pointer on an
empty `libc::cmsgdhr`, thus terminating the `cmsg_iter`.
See also mozilla/neqo#2427 for details.
This was the only case where `Instant::now()` is used in quinn-proto or quinn-udp for anything other than tests or rate-limiting logging. Making this change to keep these two crates more IO-agnostic.
|
Hi there! |
This always accepts the status set by the peer, the draft says it is only a suggestion.
- PTO is computed for the right path - crypto keys update uses 3 * max PTO of all paths - draining state uses 3 * max PTO of all paths
- PTO is computed for the right path - crypto keys update uses 3 * max PTO of all paths - draining state uses 3 * max PTO of all paths
- [x] Basic idle timeout scaffolding. - [x] Handle `PathIdle` timer expiry. - [x] Basic keep alive scaffolding. - [x] Handle `PathKeepAlive` timer expiry. - [x] quinn-proto API for setting path idle and keepalive. - [x] quinn API for setting path idle and keepalive. - [x] Allow setting path idle & keepalive defaults in `TransportConfig`. The following might perhaps better flow over to another PR - [ ] Abandon the path correctly. - [ ] Close the connection if there is no remaining path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.