Skip to content

Allow grouping by a column that has a value of "0" #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v5.2
Choose a base branch
from
Open

Allow grouping by a column that has a value of "0" #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Jsonq.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Nahid\JsonQ\Exceptions\InvalidJsonException;
use Nahid\JsonQ\Exceptions\InvalidNodeException;
use Nahid\JsonQ\Exceptions\NullValueException;
use Nahid\JsonQ\Results\ValueNotFound;

class Jsonq
{
Expand Down Expand Up @@ -187,7 +188,7 @@ public function groupBy($column)
$data = [];
foreach ($this->_map as $map) {
$value = $this->getFromNested($map, $column);
if ($value) {
if (!$value instanceof ValueNotFound) {
$data[$value][] = $map;
}
}
Expand Down