Skip to content

First Preview #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020
Merged

First Preview #32

merged 1 commit into from
May 27, 2020

Conversation

TerryFogg
Copy link
Contributor

@TerryFogg TerryFogg commented May 25, 2020

First Preview of Graphics Samples

  1. Privitives tested
  2. WPF related - untested

Description

The primitive sample demonstrates and tests various features of the primitive graphics.
Renamed the folder to graphics from graphicswpf since it will contain both primitive (non wpf) and wpf samples eventually

How Has This Been Tested?

Code run and display verified
Video has been posted on discord #UI channel

Types of changes

  • Improvement (non-breaking change that improves a sample)
  • Bug fix (fixes an issue with a current sample)
  • New Sample (adds a new sample)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

@nfbot
Copy link
Member

nfbot commented May 25, 2020

Hi @TerryFogg,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit b10ebe4 into nanoframework:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants