-
-
Notifications
You must be signed in to change notification settings - Fork 181
Update to IDF 5.4.1 and add basic ESP32_P4 support #3152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdrianSoundy
wants to merge
23
commits into
nanoframework:main
Choose a base branch
from
AdrianSoundy:IDF5_4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
19154e3
Update to IDF 5.4.1 and add basic ESP32_P4
AdrianSoundy 3b3408c
Code style fixes
nfbot 24ba077
Fix Coderabbit issues and add P4 to Azure build
AdrianSoundy 8dcbc05
Add back mbedtls_xxx for some STM32 targets
AdrianSoundy b802a6a
Update patch version and python env for dockers
AdrianSoundy 17a9937
Add libusb to docker for openocd
AdrianSoundy 70e43da
Work around for ESP_ROM_ELF_DIR issue
AdrianSoundy 4c5fe24
Correcting typos
josesimoes 730cffc
Resolve smoketest builds, header not found
AdrianSoundy d6a3b70
IDF 5_4_1 patch test
AdrianSoundy d1bfa24
Updates from review part 1
AdrianSoundy 98f3ddc
Updates for review part 2
AdrianSoundy b372c74
Ethernet and build rework
AdrianSoundy 95e59c8
Update Component registry versions to latest
AdrianSoundy fbb210a
Update Graphics_Memory.cpp code to same version for all ESP targets
AdrianSoundy e027c54
Add extra p4 config for latest hosted component
AdrianSoundy e55f10b
Update P4 config & readme
AdrianSoundy 30b9bfb
Change Wifi-remote & esp_hosted component versions used
AdrianSoundy d972d75
Update sdkconfig.default.esp32p4
AdrianSoundy f47ac2b
Add Wi-Fi Remote config for better performance on p4
AdrianSoundy 4c16457
Initial ESP32_C5 build + Build diagnostic message
AdrianSoundy 7b941fa
Add ESP_IDF_VERSION to p4 environment as test
AdrianSoundy 83ff169
Merge branch 'main' into IDF5_4
AdrianSoundy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # | ||
| # Copyright (c) .NET Foundation and Contributors | ||
| # See LICENSE file in the project root for full license information. | ||
| # | ||
|
|
||
| # need to specify linker flags here | ||
| set(CMAKE_EXE_LINKER_FLAGS " -Wl,--print-memory-usage " CACHE INTERNAL "executable linker flags") | ||
|
|
||
| # TARGET parameter to set the target that's setting them for | ||
| # optional EXTRA_COMPILE_OPTIONS with compile options to be added | ||
| macro(nf_set_compile_options) | ||
|
|
||
| # parse arguments | ||
| cmake_parse_arguments(NFSCO "" "TARGET" "EXTRA_COMPILE_OPTIONS" ${ARGN}) | ||
|
|
||
| if(NOT NFSCO_TARGET OR "${NFSCO_TARGET}" STREQUAL "") | ||
| message(FATAL_ERROR "Need to set TARGET argument when calling nf_set_compile_options()") | ||
| endif() | ||
|
|
||
| # include any extra options coming from any extra args? | ||
| target_compile_options(${NFSCO_TARGET} PUBLIC ${NFSCO_EXTRA_COMPILE_OPTIONS} -Wall -Wextra -Werror -Wno-sign-compare -Wno-unused-parameter -Wshadow -Wimplicit-fallthrough -fshort-wchar -fno-builtin -fno-common -fno-exceptions -fcheck-new ) | ||
|
|
||
| # this series has FPU | ||
| target_compile_definitions(${NFSCO_TARGET} PUBLIC -DTARGET=esp32c6 -DUSE_FPU=TRUE -DPLATFORM_ESP32 -DESP_PLATFORM) | ||
|
|
||
| endmacro() | ||
|
|
||
| # TARGET parameter to set the target that's setting them for | ||
| # optional EXTRA_LINK_FLAGS with link flags to be added | ||
| macro(nf_set_link_options) | ||
|
|
||
| # parse arguments | ||
| cmake_parse_arguments(NFSLO "" "TARGET;EXTRA_LINK_FLAGS" "" ${ARGN}) | ||
|
|
||
| if(NOT NFSLO_TARGET OR "${NFSLO_TARGET}" STREQUAL "") | ||
| message(FATAL_ERROR "Need to set TARGET argument when calling nf_set_link_options()") | ||
| endif() | ||
|
|
||
| # set optimization linker flags for RELEASE and MinSizeRel | ||
| if(CMAKE_BUILD_TYPE STREQUAL "Release" OR CMAKE_BUILD_TYPE STREQUAL "MinSizeRel") | ||
| set_property(TARGET ${NFSLO_TARGET} APPEND_STRING PROPERTY LINK_FLAGS " -Os ") | ||
| endif() | ||
|
|
||
| # include libraries in build | ||
| nf_include_libraries_in_build(${NFSLO_TARGET}) | ||
|
|
||
| # set extra linker flags | ||
| set_property(TARGET ${NFSLO_TARGET} APPEND_STRING PROPERTY LINK_FLAGS " ${NFSLO_EXTRA_LINK_FLAGS} ") | ||
|
|
||
| # set optimization flags | ||
| nf_set_optimization_options(${NFSLO_TARGET}) | ||
|
|
||
| endmacro() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # | ||
| # Copyright (c) .NET Foundation and Contributors | ||
| # See LICENSE file in the project root for full license information. | ||
| # |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # | ||
| # Copyright (c) .NET Foundation and Contributors | ||
| # See LICENSE file in the project root for full license information. | ||
| # | ||
|
|
||
| # need to specify linker flags here | ||
| set(CMAKE_EXE_LINKER_FLAGS " -Wl,--print-memory-usage " CACHE INTERNAL "executable linker flags") | ||
|
|
||
| # TARGET parameter to set the target that's setting them for | ||
| # optional EXTRA_COMPILE_OPTIONS with compile options to be added | ||
| macro(nf_set_compile_options) | ||
|
|
||
| # parse arguments | ||
| cmake_parse_arguments(NFSCO "" "TARGET" "EXTRA_COMPILE_OPTIONS" ${ARGN}) | ||
|
|
||
| if(NOT NFSCO_TARGET OR "${NFSCO_TARGET}" STREQUAL "") | ||
| message(FATAL_ERROR "Need to set TARGET argument when calling nf_set_compile_options()") | ||
| endif() | ||
|
|
||
| # include any extra options coming from any extra args? | ||
| target_compile_options(${NFSCO_TARGET} PUBLIC ${NFSCO_EXTRA_COMPILE_OPTIONS} -Wall -Wextra -Werror -Wno-sign-compare -Wno-unused-parameter -Wshadow -Wimplicit-fallthrough -fshort-wchar -fno-builtin -fno-common -fno-exceptions -fcheck-new ) | ||
|
|
||
| # this series has FPU | ||
| target_compile_definitions(${NFSCO_TARGET} PUBLIC -DTARGET=esp32p4 -DUSE_FPU=TRUE -DPLATFORM_ESP32 -DESP_PLATFORM) | ||
|
|
||
| endmacro() | ||
|
|
||
| # TARGET parameter to set the target that's setting them for | ||
| # optional EXTRA_LINK_FLAGS with link flags to be added | ||
| macro(nf_set_link_options) | ||
|
|
||
| # parse arguments | ||
| cmake_parse_arguments(NFSLO "" "TARGET;EXTRA_LINK_FLAGS" "" ${ARGN}) | ||
|
|
||
| if(NOT NFSLO_TARGET OR "${NFSLO_TARGET}" STREQUAL "") | ||
| message(FATAL_ERROR "Need to set TARGET argument when calling nf_set_link_options()") | ||
| endif() | ||
|
|
||
| # set optimization linker flags for RELEASE and MinSizeRel | ||
| if(CMAKE_BUILD_TYPE STREQUAL "Release" OR CMAKE_BUILD_TYPE STREQUAL "MinSizeRel") | ||
| set_property(TARGET ${NFSLO_TARGET} APPEND_STRING PROPERTY LINK_FLAGS " -Os ") | ||
| endif() | ||
|
|
||
| # include libraries in build | ||
| nf_include_libraries_in_build(${NFSLO_TARGET}) | ||
|
|
||
| # set extra linker flags | ||
| set_property(TARGET ${NFSLO_TARGET} APPEND_STRING PROPERTY LINK_FLAGS " ${NFSLO_EXTRA_LINK_FLAGS} ") | ||
|
|
||
| # set optimization flags | ||
| nf_set_optimization_options(${NFSLO_TARGET}) | ||
|
|
||
| endmacro() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # | ||
| # Copyright (c) .NET Foundation and Contributors | ||
| # See LICENSE file in the project root for full license information. | ||
| # |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect target definition.
The target is incorrectly defined as
esp32c6but this file is for ESP32_C5 support. This could cause target identification issues and configuration mismatches.Apply this fix:
🤖 Prompt for AI Agents