fix: added missing js reference for map layers #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, there are a couple of cases of weak references being lost because carto map does not keep refs of layers on JS-side.
This PR ensures that we keep a proper reference of
Layers
instance and its layers using a JS array.It also corrects a few types and keeps all common methods related to Layers in common file.
Additionally, method
getLayers
becomes lazy and instantiatesLayers
once during first execution, provided that native view is already initialized.Getter
mapView
becomes common and is now added to types.Certain
Layers
methods returned wrong type. See https://cartodb.github.io/mobile-android-samples/reference/com/carto/components/Layers.html#removeAll(com.carto.layers.LayerVector)Methods addAll, setAll, and removeAll have been fixed as they called certain other
Layers
instance methods withoutthis
context.Example of the problem: