Skip to content

Support for PINGs from client to server to detect connection loss #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2019
Merged

Support for PINGs from client to server to detect connection loss #30

merged 2 commits into from
May 27, 2019

Conversation

viktorm77
Copy link
Contributor

@viktorm77 viktorm77 commented May 23, 2019 •
edited
Loading

Fixes #29
Send PINGs from client to server to determine if NATS Streaming connection is still valid.

wallyqs
wallyqs approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this great contribution 💯

@wallyqs wallyqs merged commit e3b5539 into nats-io:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for PINGs from client to server to detect connection loss
2 participants
@viktorm77 @wallyqs