-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade to Rails 8.0.3 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -1,5 +1,5 @@ | |||
module ApplicationHelper | |||
def us_form_with(model: nil, scope: nil, url: nil, format: nil, **options, &block) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling form_with with model: nil is deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we want to create a form without a model like a search bar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can revise it to remove the argument in model is nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should update the default to false
to match upstream. And let anywhere currently calling explicitly with model: nil
break (fixing any current usage in template-application-rails
in this PR of course).
def us_form_with(model: nil, scope: nil, url: nil, format: nil, **options, &block) | |
def us_form_with(model: false, scope: nil, url: nil, format: nil, **options, &block) |
Ideally we would specify this as a type, so static checking would catch the callsites, but Ruby....
|
||
# Initialize configuration defaults for originally generated Rails version. | ||
config.load_defaults 7.2 | ||
config.load_defaults 8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any config changes worth calling out?
Did we run rails app:update
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I did. Nothing big, but I can leave commentary in the PR in case someone wants to change something downstream.
@@ -1,5 +1,5 @@ | |||
module ApplicationHelper | |||
def us_form_with(model: nil, scope: nil, url: nil, format: nil, **options, &block) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should update the default to false
to match upstream. And let anywhere currently calling explicitly with model: nil
break (fixing any current usage in template-application-rails
in this PR of course).
def us_form_with(model: nil, scope: nil, url: nil, format: nil, **options, &block) | |
def us_form_with(model: false, scope: nil, url: nil, format: nil, **options, &block) |
Ideally we would specify this as a type, so static checking would catch the callsites, but Ruby....
@baonguyenNava if you add "Resolves #71" to the Description it'll automatically mark that ticket as done when this PR is merged |
Major version upgrade:
release notes - See for full list of deprecations.
Then main deprecations we may need to address are in the views. Otherwise, most of the deprecations are configs.
Resoles #71
New framework defaults and configs below