Skip to content

Use precision argument on cmd #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 2, 2022
Merged

Use precision argument on cmd #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84f6026
build: windows 3.11.0a4 started failing to save the pip cache
nedbat Jan 30, 2022
d20151c
Fix precision argument when using cmd
Kludex Feb 1, 2022
34ac77f
Remove print
Kludex Feb 1, 2022
b075a9e
Merge remote-tracking branch 'origin/master' into fix/precision-cover…
Kludex Feb 1, 2022
b69b5ce
Remove isort things
Kludex Feb 1, 2022
8a796d4
last isort...
Kludex Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions coverage/cmdline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,8 @@ def command_line(self, argv):
# value, so we can get fail_under from the config file.
if options.fail_under is not None:
self.coverage.set_option("report:fail_under", options.fail_under)
if options.precision is not None:
self.coverage.set_option("report:precision", options.precision)

fail_under = self.coverage.get_option("report:fail_under")
precision = self.coverage.get_option("report:precision")
Expand Down
3 changes: 3 additions & 0 deletions tests/test_cmdline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,6 +1136,9 @@ def lcov_report(self, *args_unused, **kwargs_unused):
((20, 30, 40, 50, 60), 61, "lcov", 2),
# Command-line overrides configuration.
((20, 30, 40, 50, 60), 19, "report --fail-under=21", 2),
# Precision defined
((20, 30, 40, 50, 60), None, "report --fail-under=20.1 --precision=1", 2),
((20, 30, 40, 50, 60), None, "report --fail-under=19.9 --precision=1", 0),
])
def test_fail_under(results, fail_under, cmd, ret):
cov = CoverageReportingFake(*results)
Expand Down