Skip to content

[Snyk] Upgrade react-router-dom from 5.2.0 to 5.3.4 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade react-router-dom from 5.2.0 to 5.3.4.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 6 versions ahead of your current version.

  • The recommended version was released 3 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
medium severity Always-Incorrect Control Flow Implementation
SNYK-JS-HTTPPROXYMIDDLEWARE-9691387
386 No Known Exploit
medium severity Improper Check for Unusual or Exceptional Conditions
SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
386 No Known Exploit
Release notes
Package name: react-router-dom
  • 5.3.4 - 2022-10-02
  • 5.3.3 - 2022-05-18
  • 5.3.2 - 2022-05-17
  • 5.3.1 - 2022-04-17
  • 5.3.0 - 2021-09-03
  • 5.2.1 - 2021-08-27
  • 5.2.0 - 2020-05-11
from react-router-dom GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade react-router-dom from 5.2.0 to 5.3.4.

See this package in npm:
react-router-dom

See this project in Snyk:
https://app.snyk.io/org/mohammadnewton/project/114e7157-afe3-4de3-95db-e422d85485d2?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the react-router-dom dependency from version 5.2.0 to 5.3.4. This is an automated upgrade PR created by Snyk to address two medium severity vulnerabilities related to http-proxy-middleware. The update also includes updates to other dependencies in the package-lock.json file to ensure compatibility and address potential security concerns.

Highlights

  • Dependency Upgrade: The primary focus is upgrading react-router-dom from 5.2.0 to 5.3.4 to mitigate identified vulnerabilities.
  • Vulnerability Fix: Addresses two medium severity vulnerabilities (SNYK-JS-HTTPPROXYMIDDLEWARE-9691387 and SNYK-JS-HTTPPROXYMIDDLEWARE-9691389) associated with http-proxy-middleware.
  • package-lock.json Update: The package-lock.json file is updated to reflect the new version of react-router-dom and its transitive dependencies, including @babel/runtime, path-to-regexp, tiny-invariant, and type-fest.

Changelog

Click here to see the changelog
  • package-lock.json
    • Updates react-router-dom from version 5.2.0 to 5.3.4.
    • Updates @babel/runtime from version 7.12.5 to 7.27.1.
    • Adds type-fest as a dependency for @eslint/eslintrc, @jest/core, @jest/reporters, eslint, jest-config, jest-resolve, jest-runner, jest-runtime, and jest-snapshot.
    • Adds license information for history and hoist-non-react-statics.
    • Updates integrity hash for isarray.
    • Removes mini-create-react-context.
    • Updates path-to-regexp from version 1.8.0 to 1.9.0.
    • Updates react-router from version 5.2.0 to 5.3.4.
    • Updates tiny-invariant from version 1.1.0 to 1.3.3.
    • Updates type-fest from version 0.8.1 to 0.13.1 and marks it as optional and peer dependency.
    • Adds typescript as a peer dependency.
    • Adds license information for value-equal.
    • Updates integrity hash for isarray.
    • Updates @babel/runtime and removes its dependency on regenerator-runtime.
    • Adds type-fest as a dependency for @eslint/eslintrc, @jest/core, @jest/reporters, eslint, jest-config, jest-resolve, jest-runner, jest-runtime, and jest-snapshot.
  • package.json
    • Updates react-router-dom from version 5.2.0 to 5.3.4.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A router's path,
Upgraded to a safer route,
Vulnerabilities gone.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the react-router-dom dependency from version 5.2.0 to 5.3.4. This upgrade addresses two medium severity vulnerabilities. The changes primarily involve updating the package-lock.json and package.json files to reflect the new version and its transitive dependencies.

Summary of Findings

  • Dependency Upgrade: The pull request upgrades react-router-dom from 5.2.0 to 5.3.4, resolving two medium severity vulnerabilities.
  • Transitive Dependency Updates: The upgrade includes updates to transitive dependencies, such as @babel/runtime, path-to-regexp, tiny-invariant, and type-fest.

Merge Readiness

The pull request updates a dependency to address security vulnerabilities, which is a positive change. However, it's crucial to verify that the updated version doesn't introduce any breaking changes or regressions in the application. Since I am unable to approve the pull request, ensure that others review and approve this code before merging.

@@ -5,7 +5,7 @@
"dependencies": {
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-router-dom": "^5.2.0",
"react-router-dom": "^5.3.4",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line updates the react-router-dom version in the package.json file. Double-check that the version number is correct and matches the intended upgrade.

"react-router-dom": "^5.3.4",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants