Skip to content

[Snyk] Upgrade react-scripts from 4.0.1 to 4.0.3 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 2 versions ahead of your current version.

  • The recommended version was released 4 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
high severity Remote Memory Exposure
SNYK-JS-DNSPACKET-1293563
387 No Known Exploit
high severity Asymmetric Resource Consumption (Amplification)
SNYK-JS-BODYPARSER-7926860
387 No Known Exploit
high severity Prototype Pollution
SNYK-JS-ASYNC-2441827
387 Proof of Concept
high severity Prototype Pollution
SNYK-JS-IMMER-1019369
387 Proof of Concept
high severity Improper Handling of Extra Parameters
SNYK-JS-FOLLOWREDIRECTS-6141137
387 Proof of Concept
high severity Server-side Request Forgery (SSRF)
SNYK-JS-IP-6240864
387 Proof of Concept
high severity Improper Input Validation
SNYK-JS-URLPARSE-2407770
387 Proof of Concept
medium severity Command Injection
SNYK-JS-REACTDEVUTILS-1083268
387 Proof of Concept
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
387 No Known Exploit
medium severity Information Exposure
SNYK-JS-EVENTSOURCE-2823375
387 Proof of Concept
medium severity Open Redirect
SNYK-JS-EXPRESS-6474509
387 No Known Exploit
medium severity Cross-site Scripting
SNYK-JS-EXPRESS-7926867
387 No Known Exploit
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2332181
387 Proof of Concept
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-6444610
387 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106
387 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-8482416
387 Proof of Concept
medium severity Open Redirect
SNYK-JS-URLPARSE-1533425
387 Proof of Concept
medium severity Access Restriction Bypass
SNYK-JS-URLPARSE-2401205
387 Proof of Concept
medium severity Authorization Bypass
SNYK-JS-URLPARSE-2407759
387 Proof of Concept
low severity Cross-site Scripting
SNYK-JS-SEND-7926862
387 No Known Exploit
low severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2396346
387 No Known Exploit
critical severity Incomplete List of Disallowed Inputs
SNYK-JS-BABELTRAVERSE-5962462
387 Proof of Concept
medium severity Improper Input Validation
SNYK-JS-URLPARSE-1078283
387 No Known Exploit
medium severity Authorization Bypass Through User-Controlled Key
SNYK-JS-URLPARSE-2412697
387 Proof of Concept
low severity Cross-site Scripting
SNYK-JS-SERVESTATIC-7926865
387 No Known Exploit
Release notes
Package name: react-scripts
  • 4.0.3 - 2021-02-22
  • 4.0.2 - 2021-02-03
  • 4.0.1 - 2020-11-23
from react-scripts GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.

See this package in npm:
react-scripts

See this project in Snyk:
https://app.snyk.io/org/newtonombese1/project/440e6a9d-4fca-4917-a4e6-bdbc889565a3?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, Gemini here to provide a summary of this pull request. This PR, automatically generated by Snyk, aims to upgrade the react-scripts dependency from version 4.0.1 to 4.0.3. The primary motivation for this upgrade is to address a significant number of security vulnerabilities identified in the current version, ranging from low to critical severity, as detailed in the pull request description.

Highlights

  • Dependency Upgrade: Upgrades the react-scripts package from version 4.0.1 to 4.0.3.
  • Security Vulnerability Fixes: This upgrade resolves multiple security vulnerabilities, including critical, high, medium, and low severity issues, improving the overall security posture of the project.

Changelog

  • package.json
    • Updates the react-scripts dependency version from "4.0.1" to "4.0.3" in the dependencies section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Old code has holes,
Upgrade dependencies,
Security shines.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR, automatically generated by Snyk, proposes an upgrade of react-scripts from version 4.0.1 to 4.0.3. This is a valuable change as it addresses a significant number of security vulnerabilities, including critical and high severity ones, as detailed in the PR description. The change itself is a straightforward version bump in package.json.

While this patch upgrade is beneficial for immediate security improvements, I have a couple of points for consideration to ensure stability and to think about long-term project health.

Summary of Findings

  • Importance of Thorough Testing: A comment was made on package.json (line 8) emphasizing the need for comprehensive testing (CI, manual QA, build verification) after this react-scripts upgrade to catch any potential regressions, despite it being a patch update. Severity: medium.
  • Consideration for Future Upgrades: A comment was made on package.json (line 8) suggesting that while this upgrade to react-scripts 4.0.3 is beneficial, the team should consider planning for a future upgrade to a more recent major version (e.g., 5.x.x) to leverage newer features, performance gains, and more extensive security patches, given that 4.0.3 is also an older version. Severity: medium.

Merge Readiness

This pull request represents a positive and necessary step towards enhancing the project's security by upgrading react-scripts to version 4.0.3, addressing multiple vulnerabilities.
The change itself is minimal (a version bump in package.json) and directly targets the issues outlined by Snyk.

My review includes two main considerations, both rated as medium severity:

  1. Post-Merge Verification: It's crucial to conduct thorough testing (automated and/or manual) to ensure this dependency update doesn't negatively impact the application's stability or functionality.
  2. Long-Term Dependency Management: While 4.0.3 is an improvement, it's still an older version of react-scripts. Planning for a future upgrade to a more current major version (e.g., 5.x) should be considered for ongoing project health.

Assuming the CI pipeline passes and there's a plan for post-merge validation, this PR seems appropriate for merging to quickly address the identified security risks. As I am not authorized to approve pull requests, the final decision to merge rests with the project maintainers. These points are offered to aid in that decision and subsequent actions.

@@ -5,7 +5,7 @@
"dependencies": {
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-scripts": "4.0.1"
"react-scripts": "4.0.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This upgrade to react-scripts 4.0.3 is an important step for security. While patch versions like this one (4.0.1 to 4.0.3) are generally expected to be backward-compatible, it's always prudent to verify thoroughly.

Could you confirm what testing procedures (e.g., automated CI checks, manual QA on critical paths, build process verification) will be followed to ensure this update doesn't introduce any regressions or unexpected behavior after merging?

@@ -5,7 +5,7 @@
"dependencies": {
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-scripts": "4.0.1"
"react-scripts": "4.0.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's good to see react-scripts being updated to mitigate known vulnerabilities. As the Snyk report itself notes, version 4.0.3 was released in early 2021, making it several years old.

Looking further ahead, are there any discussions or plans to upgrade react-scripts to a more recent major version (e.g., 5.x.x)? While such an upgrade would likely be a larger effort, it could offer more comprehensive security updates, newer features, performance improvements, and better compatibility with the modern JavaScript ecosystem. This current PR is a good immediate fix, but a longer-term strategy for major dependencies might be beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants