Skip to content

[Snyk] Upgrade react-scripts from 4.0.1 to 4.0.3 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 2 versions ahead of your current version.

  • The recommended version was released 4 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
high severity Prototype Pollution
SNYK-JS-IMMER-1019369
387 Proof of Concept
high severity Server-side Request Forgery (SSRF)
SNYK-JS-IP-6240864
387 Proof of Concept
high severity Improper Handling of Extra Parameters
SNYK-JS-FOLLOWREDIRECTS-6141137
387 Proof of Concept
high severity Asymmetric Resource Consumption (Amplification)
SNYK-JS-BODYPARSER-7926860
387 No Known Exploit
high severity Prototype Pollution
SNYK-JS-ASYNC-2441827
387 Proof of Concept
high severity Improper Input Validation
SNYK-JS-URLPARSE-2407770
387 Proof of Concept
high severity Remote Memory Exposure
SNYK-JS-DNSPACKET-1293563
387 No Known Exploit
medium severity Command Injection
SNYK-JS-REACTDEVUTILS-1083268
387 Proof of Concept
medium severity Information Exposure
SNYK-JS-EVENTSOURCE-2823375
387 Proof of Concept
medium severity Open Redirect
SNYK-JS-EXPRESS-6474509
387 No Known Exploit
medium severity Cross-site Scripting
SNYK-JS-EXPRESS-7926867
387 No Known Exploit
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2332181
387 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106
387 Proof of Concept
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
387 No Known Exploit
low severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2396346
387 No Known Exploit
critical severity Incomplete List of Disallowed Inputs
SNYK-JS-BABELTRAVERSE-5962462
387 Proof of Concept
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-6444610
387 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-8482416
387 Proof of Concept
medium severity Improper Input Validation
SNYK-JS-URLPARSE-1078283
387 No Known Exploit
medium severity Open Redirect
SNYK-JS-URLPARSE-1533425
387 Proof of Concept
medium severity Access Restriction Bypass
SNYK-JS-URLPARSE-2401205
387 Proof of Concept
medium severity Authorization Bypass
SNYK-JS-URLPARSE-2407759
387 Proof of Concept
medium severity Authorization Bypass Through User-Controlled Key
SNYK-JS-URLPARSE-2412697
387 Proof of Concept
low severity Cross-site Scripting
SNYK-JS-SEND-7926862
387 No Known Exploit
low severity Cross-site Scripting
SNYK-JS-SERVESTATIC-7926865
387 No Known Exploit
Release notes
Package name: react-scripts
  • 4.0.3 - 2021-02-22
  • 4.0.2 - 2021-02-03
  • 4.0.1 - 2020-11-23
from react-scripts GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.

See this package in npm:
react-scripts

See this project in Snyk:
https://app.snyk.io/org/mohammadnewton/project/2a9da381-926c-417e-8136-77ebe2c34d98?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini or gemini-code-assist here to provide a summary of this pull request. This PR was automatically generated by Snyk to upgrade the react-scripts dependency from version 4.0.1 to 4.0.3. The primary goal of this upgrade is to address a significant number of security vulnerabilities identified in the current version, including several high and critical severity issues related to Prototype Pollution, SSRF, Command Injection, and more, as detailed in the PR description provided by Snyk. The changes involve updating the version specified in the project's package.json file.

Highlights

  • Security Fixes: This upgrade is intended to fix multiple security vulnerabilities reported by Snyk, including high and critical severity issues.
  • Automated PR: This pull request was automatically created by Snyk to propose the dependency update.

Changelog

  • package.json
    • Updated the react-scripts dependency version from 4.0.1 to 4.0.3 in the dependencies section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Dependency old,
Security holes appear,
Upgrade makes code safe.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, proposes an upgrade of react-scripts from version 4.0.1 to 4.0.3. This is an important update as it addresses a significant number of security vulnerabilities, including several with high and critical severity, as detailed in the PR description.

While the change itself is a minor version bump in package.json, it's crucial to ensure this update is integrated safely and completely. My review focuses on the implications of this change and necessary follow-up actions.

Summary of Findings

  • Missing Lock File Update: The PR updates react-scripts in package.json but does not include the corresponding package-lock.json (or yarn.lock) update. This is critical for reproducible builds and ensuring the correct dependencies are installed.
  • Necessity of Thorough Testing: react-scripts is a fundamental build dependency. Any upgrade requires comprehensive testing (build, dev server, automated tests, manual checks) to ensure no regressions are introduced.
  • Outdated Major Version of react-scripts: The project is on [email protected]. While this PR applies a patch, [email protected] is available and offers significant improvements. A plan to upgrade to v5 should be considered for future work.

Merge Readiness

This PR addresses important security vulnerabilities by upgrading react-scripts. However, before merging, the following critical and high-severity points need to be addressed:

  1. Critical: The project's lock file (package-lock.json or yarn.lock) must be updated and included in this PR to ensure reproducible and correct dependency installation.
  2. High: Confirmation of thorough testing (build, development server, automated tests, and manual checks) is required to ensure this upgrade does not introduce regressions.

The medium-severity suggestion regarding a future upgrade to [email protected] is for longer-term consideration and does not block this specific PR once the critical and high severity issues are resolved.

I am unable to approve pull requests directly. Please ensure these changes are reviewed and approved by the appropriate maintainers after the necessary actions are taken. Given the current state, I recommend against merging until the lock file is updated and testing is confirmed.

@@ -5,7 +5,7 @@
"dependencies": {
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-scripts": "4.0.1"
"react-scripts": "4.0.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to react-scripts to version 4.0.3 is a positive step for security. However, a critical piece seems to be missing: the corresponding update to the project's lock file (e.g., package-lock.json if using npm, or yarn.lock if using Yarn). The Snyk metadata indicates npm as the package manager, so a package-lock.json update is expected.

Without an updated lock file:

  • The exact dependency versions (including transitive dependencies) are not pinned, leading to potentially non-reproducible builds across different environments or at different times.
  • The npm install command might not pull the intended [email protected] or its specific dependency tree if the lock file is outdated and conflicts.

Could you please ensure that the lock file is regenerated (e.g., by running npm install) and committed as part of this PR? This is essential for the integrity and reproducibility of the build.

@@ -5,7 +5,7 @@
"dependencies": {
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-scripts": "4.0.1"
"react-scripts": "4.0.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading react-scripts is beneficial, but since it's a core dependency managing your project's build system, development server, and test execution, this change could have wide-ranging impacts.

Have you planned or executed thorough testing to confirm this upgrade doesn't introduce any regressions? This should ideally include:

  • Successful local and CI builds (npm run build).
  • Proper functioning of the development server (npm start).
  • All existing unit and integration tests passing (npm test).
  • Manual smoke testing of key application features.

Confirmation of successful testing would be important before merging.

@@ -5,7 +5,7 @@
"dependencies": {
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-scripts": "4.0.1"
"react-scripts": "4.0.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this patch to 4.0.3 (released Feb 2021) addresses specific vulnerabilities within the 4.x series, it's worth noting that [email protected] is an older major version. The latest stable major version is [email protected] (initially released Dec 2021), which includes newer features (like Webpack 5, Jest 27), bug fixes, and potentially more up-to-date underlying dependencies.

For long-term maintainability and to stay current with the React ecosystem, has the team considered a plan to upgrade to [email protected] in the near future? This current PR is a good incremental fix, but a major version upgrade should also be on the roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants