Remove url parse in favor of new URL #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarDamkjaer
force-pushed
the
remove_url_parse
branch
from
56ce732 to
5a7c9cd
Compare
eijawerner
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Url parse had some security&performance issues we'd like to be rid of. The library itself recommend we switch to just using the built in URL. However we discovered that only safari could handle non-standard protocols (such as bolt://). So we moved to using a polyfil library instead (so that we avoid the security issues and can just remove the dependency, when and if chrome&firefox add proper support for other protocols).
I had to add a workaround in the tests setup to get the tests to pass, I think the new dependency requires node 16, or it seems that way from this issue at least. We should look into upgrading our minimum node version and remove the workaround.