Skip to content

Add TestKit test skip for unified tx lifetime #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Add TestKit test skip for unified tx lifetime #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions neo4j/session_with_context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ func (s *sessionWithContext) runRetriable(
if err != nil {
// If the client returns a client specific error that means that
// client wants to rollback. We don't do an explicit rollback here
// but instead realy on pool invoking reset on the connection, that
// will do an implicit rollback.
// but instead rely on the pool invoking reset on the connection,
// that will do an implicit rollback.
state.OnFailure(conn, err, false)
s.pool.Return(ctx, conn)
continue
Expand Down
6 changes: 2 additions & 4 deletions testkit-backend/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ func (b *backend) handleTransactionFunc(isRead bool, data map[string]interface{}
txid := b.nextId()
b.transactions[txid] = tx
b.writeResponse("RetryableTry", map[string]interface{}{"id": txid})
defer delete(b.transactions, txid)
// Process all things that the client might do within the transaction
for {
b.process()
Expand Down Expand Up @@ -427,7 +426,6 @@ func (b *backend) handleRequest(req map[string]interface{}) {
b.writeError(err)
return
}
delete(b.drivers, driverId)
b.writeResponse("Driver", map[string]interface{}{"id": driverId})

case "NewSession":
Expand Down Expand Up @@ -473,7 +471,6 @@ func (b *backend) handleRequest(req map[string]interface{}) {
b.writeError(err)
return
}
delete(b.sessionStates, sessionId)
b.writeResponse("Session", map[string]interface{}{"id": sessionId})

case "SessionRun":
Expand Down Expand Up @@ -552,7 +549,6 @@ func (b *backend) handleRequest(req map[string]interface{}) {
case "TransactionClose":
txId := data["txId"].(string)
tx := b.transactions[txId]
delete(b.transactions, txId)
err := tx.Close()
if err != nil {
b.writeError(err)
Expand Down Expand Up @@ -867,5 +863,7 @@ func testSkips() map[string]string {
"stub.summary.test_summary.TestSummary.test_server_info": "Needs some kind of server address DNS resolution",
"stub.summary.test_summary.TestSummary.test_invalid_query_type": "Driver does not verify query type returned from server.",
"stub.routing.*.test_should_drop_connections_failing_liveness_check": "Needs support for GetConnectionPoolMetrics",
"stub.tx_lifetime.test_tx_lifetime.TestTxLifetime.test_managed_tx_raises_tx_managed_exec": "Failed tx functions cause a RESET not a ROLLBACK",
"stub.tx_lifetime.test_tx_lifetime.TestTxLifetime.test_unmanaged_tx_raises_tx_closed_exec": "tx.commit, tx.rollback, and tx.close are noops if the tx has already been closed",
}
}