Skip to content

Conversation

fbiville
Copy link
Contributor

@fbiville fbiville commented Jun 16, 2022

✅ TestKit PR is: neo4j-drivers/testkit#470
✅ Extra TestKit PR: neo4j-drivers/testkit#495

@fbiville fbiville marked this pull request as ready for review June 17, 2022 15:40
@fbiville fbiville changed the title Hydrate UTC DateTime messages Support UTC DateTime Structures Jun 17, 2022
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

Copy link

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok to me. However I've not spent so much time deep in thought on this, so perhaps worth getting one of the other driver authors to review as well.

@fbiville fbiville force-pushed the utc_fix branch 2 times, most recently from d5de5ac to 48265b8 Compare July 8, 2022 14:18
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@fbiville
Copy link
Contributor Author

The only failing test here is flaky. Merging this.

@fbiville fbiville merged commit 1f9a872 into 5.0 Jul 21, 2022
@fbiville fbiville deleted the utc_fix branch July 21, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants