Skip to content

Creating protocol 4.3 and uses the Route Message to get the routing table #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Oct 14, 2020

The objective of the commit/pr is create the infrastructure needed to support the version 4.3 of bolt protocol, including the handshake and the serialisation and use of the ROUTE message to get the routing table.

In manner to support the version 4.3 of the protocol, the handshake was adjusted and the version 4.0 was removed from it.

Some adjustments was done into the RoutingProcedureRunner which now instead of be a base class with the implementation of the single database routing procedure runner, it's the interface used by the runners.

@bigmontz bigmontz force-pushed the routing branch 9 times, most recently from 074ed24 to 10c51b3 Compare October 21, 2020 14:34
@bigmontz bigmontz changed the base branch from 4.2 to 4.3 November 4, 2020 15:33
@bigmontz bigmontz force-pushed the routing branch 2 times, most recently from c945316 to 7d138d7 Compare November 11, 2020 09:28
@bigmontz bigmontz changed the title Creating protocol 4.3 and put it on the handshake Creating protocol 4.3 and uses the Route Message to get the routing table Nov 11, 2020
@bigmontz bigmontz marked this pull request as ready for review November 11, 2020 09:29
@bigmontz bigmontz force-pushed the routing branch 2 times, most recently from da1f498 to 79844e9 Compare November 11, 2020 15:34
Copy link
Contributor

@gjmwoods gjmwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another masterpiece 🎨

…able

The objective of the commit/pr is create the infracture needed to support
the version 4.3 of bolt protocol, including the handshake and the serialization
and use of the ROUTE message to get the routing table.

In manner to support the version 4.3 of the protocol, the handshake was adjusted and the version 4.0 was removed from it.

Some adjustments was done into the RoutingProcedureRunner which now instead of be a base class with the implementation of the single database routing procedure runner,  it's the interface used by the runners.
@bigmontz bigmontz merged commit 8d1e7a3 into neo4j:4.3 Nov 23, 2020
@bigmontz bigmontz deleted the routing branch November 23, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants