Remove stacktrace from recoverable discovery log warnings #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to reduce the noise in the logs when recoverable discovery exceptions occur. Complete discovery failures are expected to be reported separately.
injectives
force-pushed
the
feature/loggingupdate
branch
from
fd21461 to
7fa806c
Compare
michael-simons
requested changes
Jun 24, 2021
driver/src/main/java/org/neo4j/driver/internal/cluster/RediscoveryImpl.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/org/neo4j/driver/internal/cluster/RediscoveryImpl.java
Show resolved
Hide resolved
michael-simons
approved these changes
Jun 28, 2021
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jul 8, 2021
* Remove stacktrace from recoverable discovery log warnings This is to reduce the noise in the logs when recoverable discovery exceptions occur. Complete discovery failures are expected to be reported separately. * Update class comment on RediscoveryImpl
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jul 8, 2021
* Remove stacktrace from recoverable discovery log warnings This is to reduce the noise in the logs when recoverable discovery exceptions occur. Complete discovery failures are expected to be reported separately. * Update class comment on RediscoveryImpl
This was referenced Jul 8, 2021
injectives
added a commit
that referenced
this pull request
Jul 9, 2021
* Remove stacktrace from recoverable discovery log warnings This is to reduce the noise in the logs when recoverable discovery exceptions occur. Complete discovery failures are expected to be reported separately. * Update class comment on RediscoveryImpl
injectives
added a commit
that referenced
this pull request
Jul 9, 2021
* Remove stacktrace from recoverable discovery log warnings This is to reduce the noise in the logs when recoverable discovery exceptions occur. Complete discovery failures are expected to be reported separately. * Update class comment on RediscoveryImpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reduce the noise in the logs when recoverable discovery exceptions occur. Complete discovery failures are expected to be reported separately.