Cleanup error codes #228
Merged
Cleanup error codes #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes sure direct and routing driver throw exceptions with correct error codes. Direct driver throws errors with code `ServiceUnavailable` on connection failures. Routing driver throws errors with code `ServiceUnavailable` only when rediscovery fails or no servers are available. It also throws errors with code `SessionExpired` on connection failures.
This commit introduces a dedicated named configuration class for `NodeChannel` and `WebSocketChannel`. It encapsulates information needed to establish a connection and logic of extracting values from the user-defined driver configuration.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR makes sure direct and routing driver throw exceptions with correct error codes. Direct driver throws errors with code
ServiceUnavailableon connection failures. Routing driver throws errors with codeServiceUnavailableonly when rediscovery fails or no servers are available. It also throws errors with codeSessionExpiredon connection failures.