Adding kerberos auth support #230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
suggested changes
Apr 20, 2017
There was a problem hiding this comment.
@zhenlineo looks good but I think we need to add some type checking and tests. JS is really fragile wrt to typos :)
| @@ -38,6 +38,9 @@ const auth ={ | |||
| return {scheme: "basic", principal: username, credentials: password}; | |||
| } | |||
| }, | |||
| kerberos:(base64EncodedTicket)=> { | |||
| return {scheme:"kerberos", credentials: base64EncodedTicket}; | |||
There was a problem hiding this comment.
Formatting is a bit off here
There was a problem hiding this comment.
Please add tests for this method to avoid breaking with a typo or smth like it. We should also type check given base64EncodedTicket with util.assertString() function.
|
Closing in favour of #236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.