Routing context in URI #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.3-routing-context
branch
2 times, most recently
from
da6ea56 to
27303a1
Compare
|
LG for the routing logic added. |
Fixed parsing, comparison and added tests.
Move all URL parsing functions out of `connector` to `util` because they are not really related to network connection and Bolt messages. Prohibit invalid keys and values in routing context. Add tests for URL parsing.
Commit makes it possible to specify routing parameters in Bolt URI query. These parameters are then send to server when doing rediscovery. This is true only for 3.2+ Neo4j database because it supports `getRoutingTable(context)` procedure. Renamed `GetServersUtil` to `RoutingUtil` because it now knows about both routing procedures `getServers` and `getRoutingTable`.
Connection exposes a promise resolved/rejected after INIT message. This is done via `#initializationCompleted()` function. This commit makes promise creation lazy because otherwise it results in `UnhandledPromiseRejectionWarning` if noone calls `#initializationCompleted()`.
lutovich
force-pushed
the
1.3-routing-context
branch
from
27303a1 to
4dc299d
Compare
lutovich
commented
Apr 27, 2017
| return new RoutingDriver(parseUrl(url), routingContext, USER_AGENT, authToken, config); | ||
| } else if (scheme === 'bolt://') { | ||
| if (!isEmptyObjectOrNull(routingContext)) { | ||
| throw new Error(`Routing parameters are not supported with scheme 'bolt'. Given URL: '${url}'`); |
| const connection = connect('bolt://localhost:7474'); // wrong port | ||
|
|
||
| connection.initializationCompleted().then(() => { | ||
| console.log('THEN called: ', arguments) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR makes it possible to specify routing parameters in Bolt URI query.
These parameters are then send to server when doing rediscovery. This is true only for 3.2+ Neo4j database because it supports
dbms.cluster.routing.getRoutingTable(context)procedure.Example:
bolt+routing://localhost:7687/?policy=my_policy®ion=china