check if statement text is empty on Session.run and Transaction.run #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
approved these changes
Sep 20, 2017
src/v1/session.js
Outdated
| @@ -65,6 +65,9 @@ class Session { | |||
| statement = statement.text; | |||
| } | |||
| assertString(statement, 'Cypher statement'); | |||
| if (statement.length == 0) { | |||
| throw new TypeError('Cypher statement is expected to be a non-empty string.'); | |||
There was a problem hiding this comment.
Maybe worth adding a assertCypherStatement() function in util.js that will verify given cypher is a non-empty string? It can be used in session and transaction just to avoid minor code duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.