Fix TLS tests in Node #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple TLS tests got broken when executed against 3.1 neo4j database, which generates self-signed certificate for default listen address in neo4j-server. Default listen address has been changed from IPV4 localhost to IPv6 localhost '::' to verify IPv6 support. This change made 3.1 database generate self-signed certificate with '::' hostname. Tests however tried to connect to regular 'bolt://localhost' and hostname validation failed because they expected 'localhost' but received certificate with '::'. Starting from 3.2 neo4j generates self-signed certificates based on the advertised address, which we do not change for tests and thus it's always 'localhost'. This commit fixes the problem by adding an explicit listen address for http with IPv4 localhost and default port 7474 to the neo4j config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.