Fixed timeout when acquiring connection from the pool #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was possible for timeout to kick in after connection
acquisition promise is resolved, but before timeout itself is cleared.
Pseudocode would be:
```
const acquisitionTimeout = xxx;
const f1 = () => {/* fail and clear the acquisition attempt */};
const acquisitionTimeoutId = setTimeout(f1, acquisitionTimeout);
const f2 = () => clearTimeout(acquisitionTimeoutId);
connectionAcquisitionPromise.then(f1);
```
This code allows `connectionAcquisitionPromise` to get resolved and `f1`
to get executed before `f2`. It is possible because installed callbacks
are only scheduled, not executed when promise is resolved.
This commit fixes the problem by moving `clearTimeout` to the place
that resolves the acquisition request, i.e. `Pool#release()` call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible for timeout to kick in after connection acquisition promise is resolved, but before timeout itself is cleared.
Pseudocode would be:
This code allows
connectionAcquisitionPromiseto get resolved andf1to get executed beforef2. It is possible because installed callbacks are only scheduled, not executed when promise is resolved.This PR fixes the problem by moving
clearTimeoutto the place that resolves the acquisition request, i.e.Pool#release()call.Fixes #304