Bolt V2 with point support #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow driver to negotiate version 2 of the Bolt protocol and select `Packer`/`Unpacker` based on the agreed protocol version. Struct unpacking logic moved to the V1 unpacker. Driver initially tries to newest available `Packer`/`Unpacker` and downgrades them after the handshake response, if needed.
This commit makes driver able to send and receive 2D and 3D points. Both are represented as custom `Point2D` and `Point3D` classes that contain coordinates and coordinate reference system identifier. This identifier comes as an integer from the database. It can thus be either represented as `Integer` or native `number`, when `disableLosslessIntegers` config option is set to true.
With optional `z` component. This is more consistent with Cypher, that does not differentiate between 2D and 3D points. It has only a single overloaded `point()` function.
lutovich
changed the title
ali-ince
reviewed
Mar 19, 2018
src/v1/internal/packstream-v1.js
Outdated
| let mapper = this.structMappers[signature]; | ||
| if (mapper) { | ||
| return mapper(this, buffer); | ||
| const signature = buffer.readUInt8(); |
There was a problem hiding this comment.
Does it make sense if we add size checks in existing struct unpacking logic?
src/v1/spatial-types.js
Outdated
| * @param {number} y the <code>y</code> coordinate of the point. | ||
| * @param {number|undefined} z the <code>y</code> coordinate of the point or <code>undefined</code> if point has 2 dimensions. | ||
| */ | ||
| constructor(srid, x, y, z) { |
There was a problem hiding this comment.
If we have p1 = new Point(1, 1, 0), a 2D point after construction and later on do something like p1.z = 4 we'll end up with a 3D point. I think it would be better if we could keep point's dimensions immutable, basically deciding it in constructor and not exposing it as a public property. Does it make sense?
types/v1/spatial-types.d.ts
Outdated
| y: number; | ||
| z: number | undefined; | ||
|
|
||
| constructor(srid: T, x: number, y: number, z?: number | undefined) |
There was a problem hiding this comment.
Having z?, do we still need | undefined?
|
@ali-ince thanks for the review! Comments should now be addressed. |
To catch protocol errors earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.