Support for temporal types #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes driver able to receive temporal types as query results and send them as query parameters. All types are represented by custom date-time classes because native `Date` type is quite limited. It can't represent needed millisecond range and does not have support for things like timezone. All temporal types expose understandable properties. For example `CypherDate` has `year`, `month` and `day` properties. Driver uses code adapted from https://github.com/ThreeTen/threetenbp to perform the conversions. Main difference is that driver operates on `Integer` objects and not native JavaScript numbers.
It returns ISO strings for every temporal type except DateTime with time zone ID. Later is formatted to an ISO date-time and time zone ID is appended in square brackets. Ideally driver would also include offset but there is no way to get it without a third-party library. Offset might be included in future.
And use top-level import in temporal tests.
TCK rewrites ids of nodes and relationships in received paths with fake ids that start from zero. This is done to easily compare predefined path from feature file with received path. It makes entity ids predictable. This commit removes incorrect assertion during path rewriting. Previously this assertion did not fail because `Integer#notEquals()` always returned a falsy value due to a bug.
ali-ince
approved these changes
Mar 29, 2018
src/v1/internal/packstream-v2.js
Outdated
| } | ||
|
|
||
| function packLocalTime(value, packer, onError) { | ||
| const totalNanos = cypherLocalTimeToNanoOfDay(value); |
There was a problem hiding this comment.
Maybe name this as nanoOfDay instead of totalNanos?
src/v1/internal/packstream-v2.js
Outdated
| * @param {function} onError the error callback. | ||
| */ | ||
| function packTime(value, packer, onError) { | ||
| const totalNanos = cypherLocalTimeToNanoOfDay(value.localTime); |
They will mostly be used with `neo4j.` namespace so "Cypher" prefix seems unnecessary. Types can also be imported with an alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes driver able to receive temporal types as query results and send them as query parameters. All types are represented by custom date-time classes because native
Datetype is quite limited. It can't represent needed millisecond range and does not have support for things like timezone.New types are:
Duration- representsDurationCypher typeLocalTime- representsLocalTimeCypher typeTime- representsTimeCypher typeDate- representsDateCypher typeLocalDateTime- representsLocalDateTimeCypher typeDateTimeWithZoneOffset- representsDateTimeCypher type with time zone as offset in secondsDateTimeWithZoneOffset- representsDateTimeCypher type with time zone as IDAll temporal types expose understandable properties. For example
Datehasyear,monthanddayproperties. Driver uses code adapted from https://github.com/ThreeTen/threetenbp to perform the conversions. Main difference is that driver operates onIntegerobjects and not native JavaScript numbers.Temporal types also override
toString()to return ISO 8601 strings.