Fix temporal ITs to only generate DST-safe time #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randomized tests for `DateTime` Cypher type generate random date-time values with time zone (either offset or id). They used to be flaky because sometimes generated instant was invalid. Such instant pointed to a non-existing time during a Daylight Saving Time adjustment/jump. Such time values are adjusted to the nearest valid value by the database. This made tests fail because received value was different from the sent value. This commit fixes the problem by making random `DateTime` generator never generate hour of the day that is in the DST adjustment range. It also reduces the number of test time zones to couple popular ones. This is done to make sure all tested time zones are supported by the JVM, neo4j database is running on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomized tests for
DateTimeCypher type generate random date-time values with time zone (either offset or id). They used to be flaky because sometimes generated instant was invalid. Such instant pointed to a non-existing time during a Daylight Saving Time adjustment/jump. Such time values are adjusted to the nearest valid value by the database. This made tests fail because received value was different from the sent value.This PR fixes the problem by making random
DateTimegenerator never generate hour of the day that is in the DST adjustment range. It also reduces the number of test time zones to couple popular ones. This is done to make sure all tested time zones are supported by the JVM, neo4j database is running on.