Support number props in spatial and temporal types #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, driver exposes integer values as instances of `Integer` class. This class can represent integer values larger than `Number.MAX_SAFE_INTEGER` without loss of precision. Driver can be forced to return native numbers using `disableLosslessIntegers` config option. This commit makes spatial and temporal types support `disableLosslessIntegers`. All exposed integer properties will be of type `number` when this config option is set to `true`. Internal conversions for temporal types still use `Integer` to not lose precision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, driver exposes integer values as instances of
Integerclass. This class can represent integer values larger thanNumber.MAX_SAFE_INTEGERwithout loss of precision. Driver can be forced to return native numbers usingdisableLosslessIntegersconfig option.This PR makes spatial and temporal types support
disableLosslessIntegers. All exposed integer properties will be of typenumberwhen this config option is set totrue. Internal conversions for temporal types still useIntegerto not lose precision.