Handle nanosecond normalization in duration #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Database normalizes nanoseconds to be in range from 0 to 999999999. `Duration` class previously did not calculations with given seconds and nanoseconds and could thus store non-normalized values. It also did not re-calculate values for the `toString()` function and returned incorrect value. This commit makes `Duration` class normalize given seconds and nanoseconds during construction. It also changes the `toString()` function to correctly format the normalized values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database normalizes nanoseconds to be in range from 0 to 999999999.
Durationclass previously did not calculations with given seconds and nanoseconds and could thus store non-normalized values. It also did not re-calculate values for thetoString()function and returned incorrect value.This PR makes
Durationclass normalize given seconds and nanoseconds during construction. It also changes thetoString()function to correctly format the normalized values.