Adds optional generic parameter to Node and Relationship

[1pxone]

This feature helps to pass typings of Node and Relationship properties.

• Generic is optional
• No more local overrides are needed

import { IUser } from './interfaces/user.inteface';
import { Node } from 'neo4j-driver';

export class User {
    constructor(private readonly node: Node<number, IUser>) {}

    getPassword(): string {
        return this.node.properties.password;
    }
    // ...
}

[bigmontz]

Hey @1pxone,

thanks for you contribution. For your PR be able to be merge, you need to read and sign Neo4j's CLA (https://neo4j.com/developer/cla/).

Apart of this, the PR looks really good. Just missing some unit tests to check if the type inference is happening as expected.

[1pxone]

Hey @1pxone,

thanks for you contribution. For your PR be able to be merge, you need to read and sign Neo4j's CLA (https://neo4j.com/developer/cla/).

Apart of this, the PR looks really good. Just missing some unit tests to check if the type inference is happening as expected.

@bigmontz Thanks for your reply. I've just sent signed CLA. Can you give some details about tests? Where should I put them?

[bigmontz]

We have typing tests defined for this class at test/types/graph-types.test.ts. You can run these tests by exec the command gulp run-ts-declaration-tests in the repo root. This tests check if the file have a valid TS syntax with the correct types.

Then, there you could create a Node, Relationship, etc with the property interface being supplied and check if you can navigate into the properties as expected (like in the example you provide).

[1pxone]

We have typing tests defined for this class at test/types/graph-types.test.ts. You can run these tests by exec the command gulp run-ts-declaration-tests in the repo root. This tests check if the file have a valid TS syntax with the correct types.

Then, there you could create a Node, Relationship, etc with the property interface being supplied and check if you can navigate into the properties as expected (like in the example you provide).

@bigmontz I've got it, thank you for the clarification. I've just pushed some tests, check it, please :)

[bigmontz]

🥇

Thanks @1pxone, It will be merged as soon as we get a green pipeline.

[bigmontz]

Hi @1pxone,

I've taken a look at your CLA signing and it's missing the github username there after your e-mail. You put your name instead.

Could you please resend with the correction?

More details in: https://neo4j.com/developer/cla/

[1pxone]

@1pxone

@bigmontz Hey! I've just sent it again with correction :)

[bigmontz]

Hi @1pxone,

We are having an issue in linking your commits with your Github user. It seems like you commits doesn't have the correct e-mail linked. Could you amend your commits to add your email to them?

See: https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup

Thanks.

[1pxone]

Hi @1pxone,

We are having an issue in linking your commits with your Github user. It seems like you commits doesn't have the correct e-mail linked. Could you amend your commits to add your email to them?

See: https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup

Thanks.

@bigmontz Ah my fault. I've forgotten to change config before diving to Open Source :) Now it seems correct.

[bigmontz]

Hi @1pxone,

somehow dependabot managed to add a commit in your PR and it is being blocked by the whitelist check because of this. Could you drop the commit?

5c0d8fb

Sorry for the backing and forth process

[1pxone]

Hi @1pxone,

somehow dependabot managed to add a commit in your PR and it is being blocked by the whitelist check because of this. Could you drop the commit?

5c0d8fb

Sorry for the backing and forth process

@bigmontz Finally I managed it lol :)

[bigmontz]

Thanks, @1pxone.

I will ping here when it get released.

[bigmontz]

Type improvement release in version 4.3.4.

Release notes: https://github.com/neo4j/neo4j-javascript-driver/wiki/4.3-changelog#434

cc: @1pxone