Added missing JSDOC param name #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added param originalVersionString to ServerVersion constructor
|
Hi @zraineri thanks for you contribution. For your PR be able to be reviewed, you need to read and sign Neo4j's CLA (https://neo4j.com/developer/cla/). |
|
@bigmontz I apologize for the late reply. The CLA has been read and signed |
originalVersionString in the constructor method of ServerVersion is treated as optional in the codebase (line 71). I updated the JSDOC param to match this.
bigmontz
pushed a commit
to bigmontz/neo4j-javascript-driver
that referenced
this pull request
Apr 21, 2022
Added param originalVersionString to ServerVersion constructor
bigmontz
pushed a commit
that referenced
this pull request
Apr 21, 2022
Added param originalVersionString to ServerVersion constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added param originalVersionString to ServerVersion constructor