Skip to content

Remove null handling for Node/Relationship Ids #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove null handling for Node/Relationship Ids #940

wants to merge 1 commit into from

Conversation

thelonelyvulpes
Copy link
Contributor

Remove code for handling null ids inline with updated specification regarding node/ relationship ids

@thelonelyvulpes thelonelyvulpes requested a review from bigmontz June 1, 2022 11:13
@thelonelyvulpes thelonelyvulpes mentioned this pull request Jun 1, 2022
Merged
@thelonelyvulpes thelonelyvulpes changed the title Remove null handling for ids Remove null handling for Node/Relationship Ids Jun 1, 2022
bigmontz
bigmontz requested changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the tests instead of remove it.

Node, Relationship and UnboundRelationship should be updated to reflect the new contract.

bigmontz
bigmontz approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@thelonelyvulpes thelonelyvulpes deleted the feature/remove-null-handling-for-ids branch June 17, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigmontz bigmontz bigmontz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelonelyvulpes @bigmontz