Skip to content

Refine TLS certificate handling #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

robsdedude
Copy link
Member

  • Improve API docs.
    • Document missing classes from the mTLS feature in preview.
    • Improve wording and references.
  • Made neo4j.auth_management.RotatingClientCertificateProvider an abstract class. This means it can no longer be instantiated directly. Please use the provided factory method neo4j.auth_management.RotatingClientCertificateProvider.rotating instead.
    • Analogously for the async APIs.
  • Fix missing type hint for parameter of TrustCustomCAs.__init__.

 * Improve API docs.
   * Document missing classes from the mTLS feature in preview.
   * Improve wording and references.
 * Made `neo4j.auth_management.RotatingClientCertificateProvider` an abstract
   class. This means it can no longer be instantiated directly. Please use the
   provided factory method
   `neo4j.auth_management.RotatingClientCertificateProvider.rotating` instead.
   * Analogously for the async APIs.
 * Fix missing type hint for parameter of `TrustCustomCAs.__init__`.
@robsdedude robsdedude force-pushed the refine-tls-certificate-handling branch from 0be9ba3 to 6832e66 Compare August 1, 2024 12:14
Copy link
Contributor

@gjmwoods gjmwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@robsdedude robsdedude enabled auto-merge (squash) August 7, 2024 09:02
@robsdedude robsdedude merged commit da79a0a into neo4j:5.0 Aug 7, 2024
20 checks passed
@robsdedude robsdedude deleted the refine-tls-certificate-handling branch August 7, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants