Skip to content

PEP 625 compatible distributions #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

robsdedude
Copy link
Member

I'll quote the mail we've received from PyPI

This email is notifying you of an upcoming deprecation that we have determined
may affect you as a result of your recent upload to 'neo4j-driver'.

In the future, PyPI will require all newly uploaded source distribution
filenames to comply with PEP 625. Any source distributions already uploaded
will remain in place as-is and do not need to be updated.

Specifically, your recent upload of 'neo4j-driver-5.27.0.tar.gz' is
incompatible with PEP 625 because it does not contain the normalized project
name 'neo4j_driver'.

In most cases, this can be resolved by upgrading the version of your build
tooling to a later version that supports PEP 625 and produces compliant
filenames.

If you have questions, you can email [email protected] to communicate with the
PyPI [email protected] to communicate with the PyPI administrators.

This change allows our release job running on a recent Python version to use a newer setuptools version which can produce PEP 625 compatible distribution files while still allowing the package to be installed with legacy Python versions (3.7 & 3.8).

I'll quote the mail we've received from PyPI

> This email is notifying you of an upcoming deprecation that we have determined
> may affect you as a result of your recent upload to 'neo4j-driver'.
>
> In the future, PyPI will require all newly uploaded source distribution
> filenames to comply with PEP 625. Any source distributions already uploaded
> will remain in place as-is and do not need to be updated.
>
> Specifically, your recent upload of 'neo4j-driver-5.27.0.tar.gz' is
> incompatible with PEP 625 because it does not contain the normalized project
> name 'neo4j_driver'.
>
> In most cases, this can be resolved by upgrading the version of your build
> tooling to a later version that supports PEP 625 and produces compliant
> filenames.
>
> If you have questions, you can email [email protected] to communicate with the
> PyPI [email protected] to communicate with the PyPI administrators.

This change allows our release job running on a recent Python version to use a
newer `setuptools` version which can produce PEP 625 compatible distribution
files while still allowing the package to be installed with legacy Python
versions (3.7 & 3.8).
Copy link

@RichardIrons-neo4j RichardIrons-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine I guess!

@robsdedude robsdedude enabled auto-merge (squash) November 28, 2024 16:41
@robsdedude robsdedude merged commit 2a1a772 into neo4j:5.0 Nov 28, 2024
20 checks passed
@robsdedude robsdedude deleted the dist/pep-625 branch November 28, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants