Fix coroutine not awaited warning #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a certain deadline passed, the driver will not even attempt certain IO operations. By not calling the coroutine function to then ignore it under these circumstances (causing the warning), but instead deferring creation of the coroutine until it is clear we want to await it, we avoid the warning. Functionally, this changes nothing, but makes the driver less noise (and probably a better async citizen 🏅).
MaxAake
reviewed
Dec 9, 2024
Signed-off-by: Rouven Bauer <[email protected]>
This reverts commit 6e88c40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a certain deadline passed, the driver will not even attempt certain IO operations. By not calling the coroutine function to then ignore it under these circumstances (causing the warning), but instead deferring creation of the coroutine until it is clear we want to await it, we avoid the warning.
Functionally this changes nothing, but makes the driver less noise (and probably a better async citizen 🏅).