Skip to content

Fix publishing wheels for legacy package neo4j-driver #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bin/check-dist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ else
|| check_file "${DIST}/${PACKAGE}-${VERSION}.tar.gz"); then
STATUS=1
fi
if ! (check_file "${DIST}/${NORMALIZED_PACKAGE}-${VERSION}-py3-none-any.whl" \
|| check_file "${DIST}/${PACKAGE}-${VERSION}-py3-none-any.whl"); then
STATUS=1
fi
done
fi

Expand Down
23 changes: 11 additions & 12 deletions bin/release
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ fi
source "${ROOT}/bin/dist-functions"
for PACKAGE in "neo4j-driver" "neo4j"; do
NORMALIZED_PACKAGE="$(normalize_dist_name "$PACKAGE")"

if check_file "${DIST}/${NORMALIZED_PACKAGE}-${VERSION}.tar.gz"
then
TWINE_ARGS="${TWINE_ARGS} ${DIST}/${NORMALIZED_PACKAGE}-${VERSION}.tar.gz"
Expand All @@ -31,18 +32,16 @@ for PACKAGE in "neo4j-driver" "neo4j"; do
echo "Source distribution file for ${PACKAGE} not found"
exit 1
fi
done

NORMALIZED_PACKAGE="$(normalize_dist_name "neo4j")"
if check_file "${DIST}/${NORMALIZED_PACKAGE}-${VERSION}-py3-none-any.whl"
then
TWINE_ARGS="${TWINE_ARGS} ${DIST}/${NORMALIZED_PACKAGE}-${VERSION}-py3-none-any.whl"
elif check_file "${DIST}/${PACKAGE}-${VERSION}-py3-none-any.whl"; then
TWINE_ARGS="${TWINE_ARGS} ${DIST}/${PACKAGE}-${VERSION}-py3-none-any.whl"
else
echo "Wheel distribution file for ${PACKAGE} not found"
exit 1
fi

if check_file "${DIST}/${NORMALIZED_PACKAGE}-${VERSION}-py3-none-any.whl"
then
TWINE_ARGS="${TWINE_ARGS} ${DIST}/${NORMALIZED_PACKAGE}-${VERSION}-py3-none-any.whl"
elif check_file "${DIST}/${PACKAGE}-${VERSION}-py3-none-any.whl"; then
TWINE_ARGS="${TWINE_ARGS} ${DIST}/${PACKAGE}-${VERSION}-py3-none-any.whl"
else
echo "Wheel distribution file for ${PACKAGE} not found"
exit 1
fi
done

twine upload ${TWINE_ARGS}