Skip to content

[4.4] API docs: Driver.close is not concurrency-safe #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

[4.4] API docs: Driver.close is not concurrency-safe #1148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ba361f
API docs: Driver.close is not concurrency-safe
robsdedude Mar 26, 2025
2974fef
Merge branch '4.4' into docs/non-concurrent-driver-close-4.4
robsdedude Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions neo4j/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,13 @@ def pipeline(self, **config):

def close(self):
""" Shut down, closing any open connections in the pool.

.. warning::

While the driver object is concurrency-safe, ``close`` is *not*.
Make sure you are not using the driver object or any resources
spawned from it (such as sessions or transactions) while calling
this method. Failing to do so results in unspecified behavior.
"""
self._pool.close()

Expand Down