Skip to content

Make UnsupportedServerProduct subclass of ConfigurationError #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

Make UnsupportedServerProduct subclass of ConfigurationError #1224

merged 1 commit into from
Jul 21, 2025

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Jul 21, 2025 •
edited
Loading

Amends #1164

Reconsidered the change.

  • The error shouldn't be retryable. If driver and server cannot agree on a common bolt version, it's highly unlikely they will a short moment later.
  • ServiceUnavailable is used for connectivity issues (broken sockets, failed dial up, etc.). This error is not really in that category.

RichardIrons-neo4j
RichardIrons-neo4j approved these changes Jul 21, 2025
View reviewed changes
Copy link

@RichardIrons-neo4j RichardIrons-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@robsdedude robsdedude merged commit 83f1fa1 into neo4j:6.x Jul 21, 2025
20 checks passed
@robsdedude robsdedude deleted the unsupported-server-product branch July 21, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardIrons-neo4j RichardIrons-neo4j RichardIrons-neo4j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @RichardIrons-neo4j