update documentation #152
update documentation #152
Conversation
test/examples/test_examples.py
Outdated
|
|
||
| # def test_config_trust_example(self): | ||
| # from config_trust_example import ConfigTrustExample | ||
| # pass |
There was a problem hiding this comment.
These commented out ones, I'm not entirely sure they have a mapping to the Python driver.
test/examples/test_examples.py
Outdated
| # def test_custom_auth_example(self): | ||
| # from custom_auth_example import CustomAuthExample | ||
| # pass | ||
|
|
There was a problem hiding this comment.
Also not sure if there is a python equivalent of this.
test/examples/test_examples.py
Outdated
|
|
||
| # FIXME: also check the error output like in the Java example | ||
| self.assertEqual(employee_number, -1) | ||
|
|
There was a problem hiding this comment.
This one is disabled because the behaviour is different on Python than in Java, and I'm not sure what to do. In Java, the equivalent test passes, but when this test is enabled, close() throws an exception because there was an error.
test/examples/test_examples.py
Outdated
| # def test_service_unavailable_example(self): | ||
| # from service_unavailable_example import ServiceUnavailableExample | ||
| # pass | ||
|
|
There was a problem hiding this comment.
I am not sure how to do the equivalent of neo4j.stop() that we do in the Java version.
|
I pushed this change to a new branch to make it easier to pull it into the docs build as WIP also while the PR is pending: https://github.com/neo4j/neo4j-python-driver/tree/1.2-examples-deletewhen152ismerged Feel free to delete that once this PR is merged, and please ping me so I can point docs build back to 1.2. |
| } | ||
| try: | ||
| with self._driver.session() as session: | ||
| session.write_transaction(lambda tx: tx.run("CREATE (a:Item)")) |
There was a problem hiding this comment.
When running, the test hangs here indefinitely. :/
This updates the documentation to match, as closely as possible, what's available in the Java docs. There are some comments inline with some issues that I need assistance with.