Skip to content

Max connection pool size #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2017
Merged

Max connection pool size #182

merged 3 commits into from
Sep 22, 2017

Conversation

zhenlineo
Copy link
Contributor

This is based on the top of PR #181

Adding max_connection_pool_size as well as connection_acquisition_timeout
Moved connections tests from integration test to unit test as no server is needed

Unrelated to this PR but renamed LOAD_BALANCING_STRATEGY_DEFAULT to DEFAULT_LOAD_BALANCING_STRATEGY

Zhen added 2 commits September 19, 2017 11:52
By default the max connection lifetime is infinite.
…eout

Moved connection tests from integration test to unit test as no server is needed
@zhenlineo zhenlineo changed the title 1.5 max pool size Max connection pool size Sep 21, 2017
This is to fix some error run tests on zhen's local machine
@zhenlineo zhenlineo merged commit f455216 into neo4j:1.5 Sep 22, 2017
@zhenlineo zhenlineo deleted the 1.5-max-pool-size branch September 22, 2017 12:22
@@ -201,6 +208,7 @@ def __init__(self, address, sock, error_handler, **config):
# Pick up the server certificate, if any
self.der_encoded_server_certificate = config.get("der_encoded_server_certificate")

def Init(self):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init

self.connector = connector
self.connection_error_handler = connection_error_handler
self.connections = {}
self.lock = RLock()
self.cond = Condition(self.lock)
self._max_connection_pool_size = config.get("max_connection_pool_size", DEFAULT_MAX_CONNECTION_POOL_SIZE)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make them public

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant