Rename identity to id #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -140,21 +139,21 @@ class UnboundRelationship(BaseRelationship): | |||
| """ | |||
|
|
|||
| @classmethod | |||
| def hydrate(cls, identity, type, properties=None): | |||
| def hydrate(cls, id, type, properties=None): | |||
There was a problem hiding this comment.
The name id refers to a built-in function in Python so using that name as a variable shadows that built-in. Standard practice would be to use id_ instead. This doesn't affect member attributes of objects, i.e. alice.id.
zhenlineo
force-pushed
the
1.0-entity-id
branch
from
1f2eae8 to
5ecd06d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.