Replace Session.last_bookmark with Session.last_bookmarks
#649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the attribute and made it return a list of strings instead of an optional string. Furthermore, it will return *all* initial bookmarks (if not updated by a server message since session creation) instead of only the last bookmark, which not necessarily would be the latest bookmark.
robsdedude
force-pushed
the
session-last-bookmarks
branch
5 times, most recently
from
f68f6f7 to
535041a
Compare
Added `neo4j.Bookmarks` to replace (now deprecated) `neo4j.Bookmark` and use if for managing bookmarks instead of raw bookmark stings.
robsdedude
force-pushed
the
session-last-bookmarks
branch
from
535041a to
ac74fdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the attribute and made it return a list of strings instead of an
optional string.
Furthermore, it will return all initial bookmarks (if not updated by a server
message since session creation) instead of only the last bookmark, which not
necessarily would be the latest bookmark.
Depends on neo4j-drivers/testkit#364