Skip to content

Re-introduce session config options to verify_connectivity #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2022
Merged

Re-introduce session config options to verify_connectivity #743

merged 3 commits into from
Jul 5, 2022

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Jun 3, 2022 •
edited
Loading

Also changes get_server_info that was introduced in 5.0 to accept
session config options.

Amends #654

@robsdedude robsdedude force-pushed the verify-connectivity-add-session-config branch from bba7825 to 4603f1b Compare June 3, 2022 09:47
bigmontz
bigmontz approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪂

(Just a comment about tests and the PR description 🗡️)

@robsdedude robsdedude merged commit 0723458 into neo4j:5.0 Jul 5, 2022
@robsdedude robsdedude deleted the verify-connectivity-add-session-config branch July 5, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigmontz bigmontz bigmontz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @bigmontz