Handle asyncio.CancelledError gracefully
#761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
handle-asyncio-cancelation
branch
from
c9afb30 to
d63505b
Compare
robsdedude
force-pushed
the
handle-asyncio-cancelation
branch
2 times, most recently
from
25f11bf to
cb3985d
Compare
robsdedude
force-pushed
the
handle-asyncio-cancelation
branch
from
cb3985d to
fefe0ad
Compare
Deferring the cancellation makes it much harder to reason about and might make the Python driver behave in a surprising way when cancelled.
robsdedude
force-pushed
the
handle-asyncio-cancelation
branch
from
fefe0ad to
f8cc62c
Compare
robsdedude
commented
Jul 21, 2022
bigmontz
approved these changes
Jul 21, 2022
robsdedude
commented
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.