Skip to content

Remove timeout config options introduced in 4.4.5 #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Aug 2, 2022

  • update_routing_table_timeout
  • session_connection_timeout

Server-side keep-alives communicated through configuration hints together with
connection_acquisition_timeout (which, starting with 4.4.5, includes the full
handshake, i.e., with HELLO message) are sufficient to avoid the driver
getting stuck.

Depends on:

@robsdedude robsdedude marked this pull request as ready for review August 2, 2022 13:04
 * `update_routing_table_timeout`
 * `session_connection_timeout`

Server-side keep-alives communicated through configuration hints together with
`connection_acquisition_timeout` (which, starting with 4.4.5, includes the full
handshake, i.e., with `HELLO` message) are sufficient to avoid the driver
getting stuck.
@robsdedude robsdedude force-pushed the adr-006-remove-new-timeouts branch from 0f7a280 to a52149d Compare August 2, 2022 15:46
Rename timeout parameter where its actually a acquisition_timeout
@robsdedude robsdedude merged commit 5b0c670 into neo4j:5.0 Aug 8, 2022
@robsdedude robsdedude deleted the adr-006-remove-new-timeouts branch August 8, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant