Update AsyncCondition to be based on Python 3.11 #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most notably, this changes how the async driver behaves when created while no event loop is running. Previously, this would lead to hard to predict errors only occurring once the connection pool ran full. The creation of the async driver will fail directly when created without a running async loop. This mirrors the behavior of `asyncio.Condition` that was changed in the same way from Python 3.9 to 3.11. While this might be considered a breaking change, having a partially working driver that crashes once under real load poses the real risk of not catching the mistake until the application is in production, which is much worse than failing as early as possible.
|
In fact, I misread the new Condition code in Python 3.10+. It explicitly fixes the issue that used to arises from creating async synchronization primitives when not event loop was running. The condition now binds to a loop the first time it's actually used in an async context. This is even better as it will just allow users to create an async driver in a sync function and use it asynchronously later. I'll update the PR description. |
robsdedude
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notably, this changes how the async driver behaves when created while no
event loop is running. Previously, this would lead to hard to predict errors
only occurring once the connection pool ran full.
Now, the async synchronization primitives will defer binding to an event loop
until they're used in an async context for the first time. This simply allows
users to safely create a driver without a running event loop (in a sync
context) and later use it in an async context.
Important note: this will likely only work when the user is on Python 3.10+
because the driver also relies on synchronization primitives that come with
asyncio. So their behavior depends on the used Python version.This PR got sparked from and
closes #868