Skip to content

Fix DeprecationWarning on closing driver multiple times #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

robsdedude
Copy link
Member

Closing the driver multiple times will still be allowed in future version. However, it will become a noop.

Closing the driver multiple times will still be allowed in future version.
However, it will become a noop.
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Worth adding a card labelled with 6.0 so we have it on the boards. Will be using those cards to remember to do deprecations etc at that time.

@robsdedude robsdedude merged commit a2f35e1 into neo4j:5.0 Sep 22, 2023
@robsdedude robsdedude deleted the fix-deprecation-waring-on-closing-driver-multiple-times branch September 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants