Skip to content

Conversation

petergebala
Copy link
Contributor

Hi @klobuczek

Referring back to your comment: #233 (comment)

I saw you were locking Async gem version and trying to have green build.
I was playing a bit with neo4j-ruby-driver locally. Looks like in Async 2.13 version they changed Queue implementation.
Now Queue does not inherit from Notification but it is separate object that you can pass to constructor:
socketry/async@v2.12.0...v2.13.0#diff-df8aafb695fd1c0346bb5904ac8a467d022fa17e9f018d3e337f4bc7cce0abe8R16-R21

Besides changes to the code I added Dockerfile and docker-compose for easier setup.
I guess future contributors wouldn't like to install specific version of java or neo4j to test certain scenarios on their machines.

Also csv is no longer a part of stdlib in ruby 3.4. It is a separate gem.

Please let me know if code looks ok. I am happy to change it according to your guidance.

@petergebala petergebala changed the title Upgrade async gem fix specs Upgrade async gem, fix specs, dockerize project, make ruby 3.4 compatible Mar 18, 2025
@klobuczek
Copy link
Member

@petergebala thank you for the PR. However, I'm not that keen on maintaining the 4.4 version for compatibility with newer ruby and gem versions. Could you redo the PR on 5.0 branch. We use that branch and beta driver version in production on a massive project. It should support everything 4.4 does and more. The reason it has not been released is that it does not support all the features of official ver 5 drivers and does not pass the full testkit suite. The corresponding activegraph version is 12.
We have as well given up on the cluster tests and favor testkit which is an order of magnitude more comprehensive as tests are written by neo4j staff themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants