Upgrade async gem, fix specs, dockerize project, make ruby 3.4 compatible #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @klobuczek
Referring back to your comment: #233 (comment)
I saw you were locking
Async
gem version and trying to have green build.I was playing a bit with neo4j-ruby-driver locally. Looks like in Async 2.13 version they changed
Queue
implementation.Now
Queue
does not inherit fromNotification
but it is separate object that you can pass to constructor:socketry/async@v2.12.0...v2.13.0#diff-df8aafb695fd1c0346bb5904ac8a467d022fa17e9f018d3e337f4bc7cce0abe8R16-R21
Besides changes to the code I added Dockerfile and docker-compose for easier setup.
I guess future contributors wouldn't like to install specific version of java or neo4j to test certain scenarios on their machines.
Also
csv
is no longer a part of stdlib in ruby 3.4. It is a separate gem.Please let me know if code looks ok. I am happy to change it according to your guidance.